[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libcdio-devel] Re: maybe i need more sleep, but isn't this a problem to
[Libcdio-devel] Re: maybe i need more sleep, but isn't this a problem too?
Thu, 8 May 2008 18:26:50 -0400
Robert William Fuller writes:
> Robert William Fuller wrote:
> > In mmc.c's mmc_read_cd(), shouldn't the CDIO_MMC_SET_READ_LENGTH24(...)
> > be inside the loop? Otherwise, reads exceeding MAX_CD_READ_BLOCKS will
> > be incorrect? (Also, shouldn't CDIO_MMC_SET_READ_LENGTH24 be using
> > i_blocks2?)
> Alright, I'm fixing this one too :-)
> I guess most people (including
> libcdio!) don't read more than 16 sectors at a time, so they don't hit
> the buffer overrun here.
Yeah, I confess there was a bit of flakiness there.