[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] memory reaping in libhurd-slab
From: |
Marcus Brinkmann |
Subject: |
Re: [PATCH] memory reaping in libhurd-slab |
Date: |
Mon, 22 Sep 2003 00:30:38 +0200 |
User-agent: |
Mutt/1.5.4i |
On Sun, Sep 21, 2003 at 08:36:31PM +0200, Johan Rydberg wrote:
> Here's a patch that adds functionality for returning unused memory to
> the system. It also removes the need for a initialization function
> (memory for slab spaces is now allocated with malloc.)
>
> Comments please.
Your patch doesn't apply. Please also make patches with -p, so we see
function names in the diff. I also spotted one or two mistakes in the
comments ("is" instead "are", a " ; " that is better a ", so", and an odd
"complete" that I interpret as "free" or "empty").
If you can provide a patch that applies, I'll put it in.
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' GNU http://www.gnu.org address@hidden
Marcus Brinkmann The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/