l4-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for serial port initialization


From: Marco Gerards
Subject: Patch for serial port initialization
Date: 22 Sep 2003 00:11:47 +0200
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

Hi,

The initialization of the serial driver is not correct.  This patch
fixes the driver.

Thanks,
Marco



Changelog entry for both laden and wortel:

2003-09-21  Marco Gerards  <address@hidden>

        * output-serial.c (serial_init): Make sure the order of the
        arguments of outb are correct.

diff -upr ../hurd-l4/laden/output-serial.c ./laden/output-serial.c
--- ../hurd-l4/laden/output-serial.c    2003-09-21 23:47:44.000000000 +0200
+++ ./laden/output-serial.c     2003-09-19 20:50:12.000000000 +0200
@@ -106,7 +106,7 @@ serial_init (const char *driver_cfg)
     }
 
   /* Parity bit.  */
-  outb (0x80, UART_LCR);
+  outb (UART_LCR, 0x80);
 
   /* FIXME: Wait a bit.  Would be nice to have a real sleep function.  */
   for (busy_wait_var = 0; busy_wait_var < 1000000; busy_wait_var++);
diff -upr ../hurd-l4/wortel/output-serial.c ./wortel/output-serial.c
--- ../hurd-l4/wortel/output-serial.c   2003-09-21 23:47:56.000000000 +0200
+++ ./wortel/output-serial.c    2003-09-19 20:48:26.000000000 +0200
@@ -107,7 +107,7 @@ serial_init (const char *driver_cfg)
     }
 
   /* Parity bit.  */
-  outb (0x80, UART_LCR);
+  outb (UART_LCR, 0x80);
 
   /* FIXME: How long do we have to wait? */
   l4_sleep (l4_time_period (L4_WORD_C (100000)));





reply via email to

[Prev in Thread] Current Thread [Next in Thread]