Re: Bugs in laden (?)

[Marcus Brinkmann]

On Wed, Sep 17, 2003 at 11:52:26PM +0200, Bas Wijnen wrote:
> And of course I keep my eyes open for bugs.  I think I've found some.  If I'm
> right, then fix them, if not then tell me why not ;-)
> 
> - file laden/ia32-cmain.c, line 261-266 is:
> 
>       if (mbi->mem_lower & 0x2ff)
>         panic ("Lower memory end address 0x%x is unaligned",
>                mbi->mem_lower);
>       if (mbi->mem_upper & 0x2ff)
>         panic ("Upper memory end address 0x%x is unaligned",
>                mbi->mem_upper);
> 
> I think both checks should be with (1 << 10) - 1 = 0x3ff, not 0x2ff.  On
> lines 247-248 (1 << 10) - 1 is used by the way, perhaps it would be nice to
> use the same notation in both places.

Oh yes.  I can fix it tomorrow, or maybe you want to send in a patch that I
can just apply? :)
 
> - file laden/laden.c, line 132 says (in the help text):
> "  -r, --reboot      reboot the system at error\n",
> while line 174 (the implementation of the option) says:
> else if (!strcmp (argv[i], "-r") || !strcmp (argv[i], "--reset"))
> These should be equal (reset or reboot)

Right.  This should be reset (we don't know if we reboot after a reset).
Same as above.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    address@hidden
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/