koha-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Koha-devel] Patch for Koha 2.2.0RC2


From: Paul POULAIN
Subject: Re: [Koha-devel] Patch for Koha 2.2.0RC2
Date: Mon Nov 22 08:20:02 2004
User-agent: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.2) Gecko/20040804

Andrés Tarallo a écrit :

When you display the detail of a biblio the word subject (in bold) doesnt appears, it just appears the subjects. However with my patch this word appears.

Maybe someone with a deeper knowldge of html templates can give a more elegant solution, this one just works ;).

That's what I thought :
In this case, my patch is better :
show "subject(s):" before subject(s) if there is at least one.
If there is none, show nothing. so i commit mine (and thank you for the report even if the solution was not the best ;-) )

I don't understand what it does : it just hide (in opac-main.tmpl) the :
<!-- TMPL_IF name="subject" --><b>Subject:</b><!-- /TMPL_IF -->

So I think it's better to change this line into
<!-- TMPL_IF name="subjects" --><b>Subject(s):</b><!-- /TMPL_IF -->
to have "Subject(s): " before the subjects when there is at least one.

Your opinion ?



--
Paul POULAIN
Consultant indépendant en logiciels libres
responsable francophone de koha (SIGB libre http://www.koha-fr.org)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]