Re: [H-source-users] [PATCH 1/6] Hardware: rename Notebooks, netbook, tablet PC to computers

[bill-auger]

this probably suggests a documentation issue also - for the
'notebook' device category, the documentation is lacking
precision and supposes that "notebooks" are the only complete
computers accepted - the category is presented as "Notebooks,
netbooks, tablet PC", which are all categorized as the
'notebook' device type

that is not so bad, but it is outdated terminology - these days,
no one refers to any computers as notebooks, netbooks, or
tablet PCs - i would suggest a further adjustment to this patch,
to present the category as "laptops and tablets" - "portable computers"
would be the most appropriate, if not for mobile phones - presumably,
mobile phones would not be suitable for the 'notebooks' category - 
its just one of those legacy issues which need finessing, in order
to remain relevant as the times change

these are not the only strings which relate to this device category -
in several other places, it is referred to as the 'notebooks' category
- "Computers" would be too general for the 'notebooks' category, 
especially if/when categories for SBC's, routers, and phones
are added (as i think they should be) - then the documentation
will also need an update

the current documentation:
> In case of notebooks
> 
> In the case of notebooks you have to insert the vendor name of
> your notebook by choosing from a list of allowed vendors
> 
> In case of other devices
> 
> If the device is not a notebook you don't have to insert the vendor name,

the revised documentation would be something like:

> Complete Computers
> 
> For complete computers (laptops, tablets, SBCs, phones, routers, etc)
> select the vendor name from the list of known vendors.
>
> Other Devices
> 
> If the "device" is not a complete computer,
> you can not select the vendor name,

i changed that final note to "you can not select the vendor name"
because that note is not applicable - only the form for
'netbooks' has a 'vendor' field (presumably categories for SBCs, phones,
and routers would also need a 'Vendor' field) - but it is not possible
to select a vendor for any other device category - the forms for
peripheral devices do not have a 'Vendor' field - those have a
"VendorID:ProductID" field instead; so no one would be confused
by the absence of that final note

also, to nit-pick "vendor" is not the appropriate name for this field -
the vendor of a router or mobile phone, for example, is usually the
service provider (eg: comcast, t-mobile, etc) - what we really want here
is the "manufacturer" (eg: linksys, samsung, LG, etc) - "manufacturer" is
who made it - "vendor" is who sold it, which is not relevant

i suggest this alternative patch instead - it is on the savannah
'wip-display-strings' branch

diff --git a/Application/Include/languages.php 
b/Application/Include/languages.php
index 2d59c6a..4677080 100644
--- a/Application/Include/languages.php
+++ b/Application/Include/languages.php
@@ -277,7 +277,7 @@ class Lang
                                /*0216*/"works with 3D acceleration"    =>      
"funziona con accelerazione 3D",
                                /*0217*/"works, but without 3D acceleration"    
=>      "funziona, ma senza accelerazione 3D",
                                /*0218*/"it does not work"      =>      "non 
funziona",
-                               /*0219*/"Notebooks, netbooks, tablet PC"        
=>      "Notebooks, netbooks, tablet PC",
+                               /*0219*/"Laptops and tablets"   =>      
"Laptops and tablets",
                                /*0220*/"Wifi cards"    =>      "Schede wifi",
                                /*0221*/"Video cards"   =>      "Schede video",
                                /*0222*/"Printers and multifunction"    =>      
"Stampanti e multifunzione",
@@ -643,7 +643,7 @@ class Lang
                                /*0216*/"works with 3D acceleration"    =>      
"funciona con aceleración 3D",
                                /*0217*/"works, but without 3D acceleration"    
=>      "funciona, pero sin aceleración 3D",
                                /*0218*/"it does not work"      =>      "no 
funciona",
-                               /*0219*/"Notebooks, netbooks, tablet PC"        
=>      "Computadores portátiles, subportátiles, tablet PC",
+                               /*0219*/"Laptops and tablets"   =>      
"Portátiles y tabletas",
                                /*0220*/"Wifi cards"    =>      "Tarjetas de 
red inalámbrica",
                                /*0221*/"Video cards"   =>      "Tarjetas de 
video",
                                /*0222*/"Printers and multifunction"    =>      
"Impresoras y multifuncionales",
@@ -1014,7 +1014,7 @@ class Lang
                                /*0216*/"works with 3D acceleration"    =>      
"fonctionne avec accélération 3D",
                                /*0217*/"works, but without 3D acceleration"    
=>      "fonctionne, mais sans accélération 3D",
                                /*0218*/"it does not work"      =>      "ne 
fonctionne pas",
-                               /*0219*/"Notebooks, netbooks, tablet PC"        
=>      "Notebooks, netbooks, tablettes",
+                               /*0219*/"Laptops and tablets"   =>      
"Ordinateurs portables et tablettes",
                                /*0220*/"Wifi cards"    =>      "Cartes wifi",
                                /*0221*/"Video cards"   =>      "Cartes 
graphiques",
                                /*0222*/"Printers and multifunction"    =>      
"Imprimantes et multifonctions",
@@ -1573,7 +1573,7 @@ class Lang
                                /*0216*/"works with 3D acceleration"    =>      
"Λειτουργεί με επιτάχυνση 3D",
                                /*0217*/"works, but without 3D acceleration"    
=>      "Λειτουργεί, αλλά χωρίς επιτάχυνση 3D",
                                /*0218*/"it does not work"      =>      "Δεν 
λειτουργεί",
-                               /*0219*/"Notebooks, netbooks, tablet PC"        
=>      "Φορητοί υπολογιστές, Υπο-φορητοί, Ταμπλέτες",
+                               /*0219*/"Laptops and tablets"   =>      
"φορητοί υπολογιστές και tablet",
                                /*0220*/"Wifi cards"    =>      "Κάρτες wifi",
                                /*0221*/"Video cards"   =>      "Κάρτες 
γραφικών",
                                /*0222*/"Printers and multifunction"    =>      
"Εκτυπωτές και πολυεργαλεία",
@@ -1894,7 +1894,7 @@ class Lang
                                /*0216*/"works with 3D acceleration"    =>      
"funciona com aceleração 3D",
                                /*0217*/"works, but without 3D acceleration"    
=>      "funciona, mas sem aceleração 3D",
                                /*0218*/"it does not work"      =>      "não 
funciona",
-                               /*0219*/"Notebooks, netbooks, tablet PC"        
=>      "Notebooks, netbooks, tablet PC",
+                               /*0219*/"Laptops and tablets"   =>      
"Laptops e tablets",
                                /*0220*/"Wifi cards"    =>      "Placas wifi",
                                /*0221*/"Video cards"   =>      "Placas de 
vídeo",
                                /*0222*/"Printers and multifunction"    =>      
"Impressoras e multifuncionais",