[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43101: [PATCH v2] Add version number in release ISO
From: |
Julien Lepiller |
Subject: |
bug#43101: [PATCH v2] Add version number in release ISO |
Date: |
Mon, 31 Aug 2020 16:13:46 +0200 |
Le Mon, 31 Aug 2020 08:18:44 +0200,
Mathieu Othacehe <othacehe@gnu.org> a écrit :
> Hey Julien,
>
> Thanks for the v2 :)
>
> > (inherit iso9660-image)
> > - (operating-system installation-os))))
> > + (operating-system installation-os)
> > + (partitions (match (image-partitions
> > iso9660-image)
> > + ((boot others ...)
> > + (cons
> > + (partition
> > + (inherit boot)
> > + (label (string-append "GUIX_"
> > system "_"
> > +
> > %guix-version)))
> > + others)))))))
>
> We could maybe factorize this in something like:
>
> --8<---------------cut here---------------start------------->8---
> (define (image-with-label image label)
> ...)
> --8<---------------cut here---------------end--------------->8---
>
> that would be put in (gnu system image).
>
> Otherwise, looks fine to me :)
>
> Thanks again,
>
> Mathieu
Pushed as 036f23f053ee6bd34c6d387debb4a9166561dd02 to
7b2ac4768721ccab1782daad99a7cb1be0ed01ee, thank you!