[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43101] [PATCH v2] Add version number in release ISO
From: |
Julien Lepiller |
Subject: |
[bug#43101] [PATCH v2] Add version number in release ISO |
Date: |
Sun, 30 Aug 2020 21:52:30 +0200 |
Here's v2 of the patch series. I've added one patch to (gnu ci) to set
the version number in generated ISOs, and fixed other issues in the
previous version of the patches.
Le Sun, 30 Aug 2020 11:11:08 -0400,
Julien Lepiller <julien@lepiller.eu> a écrit :
> Yes, it makes sense! I'll send a patch for that too. Thank you!
>
> Le 30 août 2020 11:05:27 GMT-04:00, Mathieu Othacehe
> <othacehe@gnu.org> a écrit :
> >
> >Hello Julien,
> >
> >Thanks for this patch!
> >
> >>>Please include (gnu image) and avoid ‘@’.
> >>
> >> (gnu image) is already imported, but conflicts with another module
> >>
> >for partition, leading to a compilation error. What should I do?
> >
> >You can maybe write something like:
> >
> >--8<---------------cut here---------------start------------->8---
> >#:use-module ((srfi srfi-1) #:hide (partition))
> >--8<---------------cut here---------------end--------------->8---
> >
> >> I'll add the architecture in there too, as per discussion in the
> >osinfo-db MR.
> >
> >Do you think it could be useful to add the same mechanism to ISO
> >images built by the CI? In that case, you could maybe use the same
> >mechanism in
> >(gnu ci) and label the boot partition with %guix-version?
> >
> >Thanks,
> >
> >Mathieu
0001-guix-system-Add-label-option.patch
Description: Text Data
0002-gnu-ci-Set-label-in-iso9660-jobs.patch
Description: Text Data
0003-Makefile.am-Set-iso-label.patch
Description: Text Data