[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40643] [PATCH] git-version: Handle invalid arguments gracefully

From: Ludovic Courtès
Subject: [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully
Date: Fri, 17 Apr 2020 23:16:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Jakub,

Jakub Kądziołka <address@hidden> skribis:

> * guix/git-download.scm (git-version): Add a check for commit ID length.
> ---
> If you're curious for the motivation, see [1]. This took a while to
> debug, so I'm hoping to ease this for the next person who inevitably
> stumbles upon this. Is a change like this okay?

Yes, I think so.  The ‘error’ procedure is not great, we would rather
use ‘raise’ with a ‘&message’ condition (which additionally allows for
i18n) but it’s no big deal here.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]