[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40643] [PATCH] git-version: Handle invalid arguments gracefully

From: Jakub Kądziołka
Subject: [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully
Date: Wed, 22 Apr 2020 00:45:45 +0200

On Fri, Apr 17, 2020 at 11:16:44PM +0200, Ludovic Courtès wrote:
> Hi Jakub,
> Jakub Kądziołka <address@hidden> skribis:
> > * guix/git-download.scm (git-version): Add a check for commit ID length.
> > ---
> > If you're curious for the motivation, see [1]. This took a while to
> > debug, so I'm hoping to ease this for the next person who inevitably
> > stumbles upon this. Is a change like this okay?
> Yes, I think so.  The ‘error’ procedure is not great, we would rather
> use ‘raise’ with a ‘&message’ condition (which additionally allows for
> i18n) but it’s no big deal here.

I considered using raise instead, but I couldn't get it to work
properly. I was getting a "Wrong type (expecting exact integer)" error

  (condition (&message
    (message "git-version: commit ID unexpectedly short"))))

Do you know why that might be?

Jakub Kądziołka

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]