[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo
From: |
Christopher Baines |
Subject: |
[bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo |
Date: |
Sun, 15 Mar 2020 21:26:46 +0000 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Leo Famulari <address@hidden> writes:
> On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote:
>> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable.
>
> Thanks for this patch series Sebastian! Overall it looks good...
>
> I only have one nitpick:
>
>> + ;; Skip the only failing test "test_parse_url"
>> + (invoke "pytest" "-vv" "-k" "not test_parse_url")
>> + #t)))))
>
> How does the test fail? We should add comments explaining why tests are
> skipped, not just that they are fail so we skip them :)
I did see this when reviewing the patches, but I didn't think to look at
it like this. It's the proper question to ask though.
Out of interest, I built the package without skipping that test, and
that failure looks related to the test trying to access the network, so
disabling it is probably justified.
> And while you are adding that comment or fixing the test, can you rebase
> the patches on the current master branch? They no longer apply due to
> other changes in python-xyz.scm.
If you have an up to date copy of master, this could be because I merged
the patches a few hours ago.
Thanks,
Chris
signature.asc
Description: PGP signature
- [bug#39292] [PATCH 04/10] gnu: Add python-d2to1, (continued)
- [bug#39292] [PATCH 04/10] gnu: Add python-d2to1, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 02/10] gnu: Add python-easygui, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 05/10] gnu: Add python-colour, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 09/10] gnu: Add python-tenacity, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 07/10] gnu: Add python-pyprind, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 06/10] gnu: Add python-gphoto2, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 10/10] gnu: Add rapid-photo-downloader, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 03/10] gnu: Add python-rawkit, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 08/10] gnu: Add python-colorlog, Sebastian Schott, 2020/03/07
- [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo, Leo Famulari, 2020/03/15
- [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo,
Christopher Baines <=