[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo

From: Leo Famulari
Subject: [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo
Date: Sun, 15 Mar 2020 14:47:28 -0400

On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote:
> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable.

Thanks for this patch series Sebastian! Overall it looks good...

I only have one nitpick:

> +             ;; Skip the only failing test "test_parse_url"
> +             (invoke "pytest" "-vv" "-k" "not test_parse_url")
> +             #t)))))

How does the test fail? We should add comments explaining why tests are
skipped, not just that they are fail so we skip them :)

And while you are adding that comment or fixing the test, can you rebase
the patches on the current master branch? They no longer apply due to
other changes in python-xyz.scm.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]