[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29646: [PATCH] skalibs reproducible issue (reopen)

From: Ludovic Courtès
Subject: bug#29646: [PATCH] skalibs reproducible issue (reopen)
Date: Mon, 11 Dec 2017 17:08:35 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)


"Z. Ren" <address@hidden> skribis:

> Previously, we submitted a patch that intended to fix the unreproducible 
> issue of the package skalibs (#28017). Unfortunately, the patch we submitted 
> only partially fixed the issues, i.e,. for the .a file 
> (lib/skalibs/libskarnet.a). However, the .so file (lib/ is 
> still non-deterministic.
> After investigation, we find that in the Makefile, 'sort' should be applied 
> associated with 'wildcard', rather than with only ALL_SRCS. 
> To validate the fix, we applied "guix build --check --no-grafts --rounds=2 
> skalibs" with the patched skarnet.scm, over three PCs (with guix 
> 316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the 
> built files. Under our testing setup, the attached patch fixes the issues for 
> the .a/.so files for skalibs. Hope the patch is correct this time, and sorry 
> that the previous submitted patch failed to resolve all the unreproducible 
> issues.

I confirm that it builds reproducibly on my laptop with --rounds=2 (a
weaker test that what you did!).

> From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001
> From: Z. Ren <address@hidden>
> Date: Sun, 10 Dec 2017 22:23:32 +0800
> Subject: [PATCH] fix the unreproducible issue for skalibs
> ---
>  gnu/packages/skarnet.scm | 4 ++--

I adjusted the commit log and committed.

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]