[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Thursday 18th: ‘core-updates-frozen’ sprint!
From: |
zimoun |
Subject: |
Re: Thursday 18th: ‘core-updates-frozen’ sprint! |
Date: |
Wed, 24 Nov 2021 12:07:50 +0100 |
Hi,
On Mon, 22 Nov 2021 at 15:13, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> 2. Disable the problematic tests. You may need to disable a whole test suite
> of
> similarly faulted tests, if they all behave the same.
I am becoming crazy… For instance this test randomly* fails:
@test mul!(C, vf, transpose(vf), 2, 3) == 2vf*vf' .+ 3C0
<https://github.com/JuliaLang/julia/blob/v1.6.3/stdlib/LinearAlgebra/test/matmul.jl#L155>
Therefore, I add,
--8<---------------cut here---------------start------------->8---
(substitute* "stdlib/LinearAlgebra/test/matmul.jl"
(("@test mul\\!\\(C, vf, transpose\\(vf\\), 2, 3\\) == 2vf\\*vf'
\\.+ 3C0")
"@test_broken @test mul!(C, vf, transpose(vf), 2, 3) == 2vf*vf'
.+ 3C0")
(substitute* "test/math.jl"
(("@test isinf\\(log1p\\(-one\\(T\\)\\)\\)")
"@test_broken isinf(log1p(-one(T)))"))))
--8<---------------cut here---------------end--------------->8---
So far, so good. Then I get:
--8<---------------cut here---------------start------------->8---
Error During Test at
/tmp/guix-build-julia-1.6.3.drv-0/julia-1.6.3/test/math.jl:278
Unexpected Pass
Expression: isinf(log1p(-(one(T))))
Got correct result, please change to @test if no longer broken.
--8<---------------cut here---------------end--------------->8---
and thus the build is reported as failed. Argh!! Ok, because these 2
tests are random, I replace the snippet above by:
--8<---------------cut here---------------start------------->8---
(substitute* "stdlib/LinearAlgebra/test/matmul.jl"
(("@test mul\\!\\(C, vf, transpose\\(vf\\), 2, 3\\) == 2vf\\*vf'
\\.+ 3C0")
"")
(substitute* "test/math.jl"
(("@test isinf\\(log1p\\(-one\\(T\\)\\)\\)")
""))))
--8<---------------cut here---------------end--------------->8---
And now, something magical happens, I get this error with parenthesis:
--8<---------------cut here---------------start------------->8---
Test Failed at
/tmp/guix-build-julia-1.6.3.drv-0/julia-1.6.3/usr/share/julia/stdlib/v1.6/LinearAlgebra/test/matmul.jl:155
Expression: mul!(C, vf, transpose(vf), 2, 3) == (2vf) * vf' .+ 3C0
--8<---------------cut here---------------end--------------->8---
What?! And AFAIU, it is not in the test suite.
Do I miss something with ’substitute*’?
Cheers,
simon
*randomly: because I do not know why, nothing is random with
computer. ;-)
PS: Note that current Julia master contains this test:
@test mul!(C, vf, transpose(vf), 2, 3) ≈ 2vf*vf' .+ 3C0
https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/test/matmul.jl#L155
I am trying to ’substitute*’ with that. Then I give up for now.
- Thursday 18th: ‘core-updates-frozen’ sprint!, Ludovic Courtès, 2021/11/17
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, Ricardo Wurmus, 2021/11/17
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, Ludovic Courtès, 2021/11/19
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, Ricardo Wurmus, 2021/11/19
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, Ludovic Courtès, 2021/11/22
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, zimoun, 2021/11/22
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!, Maxim Cournoyer, 2021/11/22
- Re: Thursday 18th: ‘core-updates-frozen’ sprint!,
zimoun <=
- ‘core-updates-frozen’: julia status, zimoun, 2021/11/24
- Re: ‘core-updates-frozen’: julia status update, zimoun, 2021/11/25