[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock |
Date: |
Thu, 2 Sep 2021 13:33:58 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Sep 02, 2021 at 10:56:49AM +0200, Carlos Maiolino wrote:
> On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote:
> > CC-ing Javier...
> >
> > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote:
> > > Hi.
> > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote:
> > > > Good day list,
> > > > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino
> > > > <[1]cmaiolino@redhat.com>
> > > > a écrit :
> > > >
> > > > [..]
> > > > Thanks for spotting this!
> > > >
> > > > I'm adding the maintainers in CC. Carlos who commit the patch I'm
> > > > fixing, agreed on the content.
> > >
> > > I didn't test the patch itself yet, but I've reproduced the issue. I was
> > > quite
> > > sure I had tested this patch on a V4 fs, but looks like I miscalculated
> > > the
> > > sizing. Thanks again. I'll try to test the patch here asap.
> >
> > Did you test this patch? If yes may I add your Tested-by to it?
>
> Yup, patch works fine, just finished testing it, I was just trying to
> understand
> where/why I miscalculated the inode size on V4 filesystems, and the reason was
> the same why Erwan split the last/first members of inode v2/v3 in two
> different
> unused structs.
>
> Feel free to add to the patch:
>
> Tested-by: Carlos Maiolino <cmaiolino@redhat.com>
Cool! Thanks a lot!
Daniel
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Daniel Kiper, 2021/09/01
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Carlos Maiolino, 2021/09/01
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Carlos Maiolino, 2021/09/02
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock,
Daniel Kiper <=
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Erwan Velu, 2021/09/02
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Daniel Kiper, 2021/09/02
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Erwan Velu, 2021/09/02
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Daniel Kiper, 2021/09/02
- Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock, Erwan Velu, 2021/09/02
Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock), Glenn Washburn, 2021/09/07
Re: Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock), Daniel Kiper, 2021/09/08