[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memcpy() in lib/fdt.c
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: memcpy() in lib/fdt.c |
Date: |
Tue, 10 Dec 2013 16:55:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
Go ahead
On 10.12.2013 16:38, Leif Lindholm wrote:
> Hi,
>
> There is a typo in fdt.c, invoking memcpy() rather than grub_memcpy().
> Suggested trivial fix:
>
> diff --git a/grub-core/lib/fdt.c b/grub-core/lib/fdt.c
> index 9c886fc..9f34dc7 100644
> --- a/grub-core/lib/fdt.c
> +++ b/grub-core/lib/fdt.c
> @@ -219,8 +219,8 @@ static int rearrange_blocks (void *fdt, unsigned int
> clearan
> grub_fdt_set_off_dt_strings (fdt, off_dt_strings);
>
> /* Copy reordered blocks back to fdt. */
> - memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap,
> - grub_fdt_get_totalsize (fdt) - off_mem_rsvmap);
> + grub_memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap,
> + grub_fdt_get_totalsize (fdt) - off_mem_rsvmap);
>
> grub_free(tmp_fdt);
> return 0;
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature
- memcpy() in lib/fdt.c, Leif Lindholm, 2013/12/10
- Re: memcpy() in lib/fdt.c,
Vladimir 'φ-coder/phcoder' Serbinenko <=