[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: kern/efi/mm.c - MAX_USABLE_ADDRESS

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: kern/efi/mm.c - MAX_USABLE_ADDRESS
Date: Tue, 10 Dec 2013 17:00:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

On 10.12.2013 15:59, Leif Lindholm wrote:
> On Mon, Dec 09, 2013 at 10:17:20PM +0100, Leif Lindholm wrote:
>> On Mon, Dec 09, 2013 at 08:08:39PM +0100, Vladimir 'φ-coder/phcoder' 
>> Serbinenko wrote:
>>>> A simple fix would be to just stack the ifdefs, but a better one might
>>>> be to move the define to one of <cpu/efi/memory.h> (which is currently
>>>> a dummy for all platforms, simply including <efi/memory.h>) or types.h.
>>> cpu/efi/memory.h is a possibility. cpu/types.h isn't because it's, at
>>> least partially, EFI limitation (due to EFI bugs), not CPU.
>> Ah, ok - that makes sense then.
> How about the attached?
You need to prefix define with GRUB_EFI_ as soon as it's a global define
and not limited to one file. Otherwise patch looks good. Can you send
corrected version?
> Compile tested for arm/arm64/i386/x86_64, runtime tested on arm64.
> /
>     Leif
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]