|
From: | Doug Nazar |
Subject: | Re: Big Endian fix patch |
Date: | Wed, 28 Jul 2010 12:30:47 -0400 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 |
On 2010-07-28 11:51 AM, Lennart Sorensen wrote:
I was wondering a bit why tab completion for ls doesn't work on md 1.x devices. If I do:ls (md/0<tab>, I get ls (md/0, Well since I don't have any partitions, that doesn't help anything). Also if I do: ls (md/0)/<tab> I get nothing. ls (md/0)/ does work, but the tab completion refuses to believe it could work. I miss tab completition. :)
Think I spotted this by code review. normal/completion.c:250 dir = grub_strchr (current_word, '/');It looks for a starting '/' but I bet it's hitting the '/' in the new-style md names. It should probably be
dir = grub_strchr (current_word + grub_strlen(device), '/');or something similar. I've just started setting up a test since all my arrays were under an LVM. It'll take me a little while to test with this slow setup.
Doug
[Prev in Thread] | Current Thread | [Next in Thread] |