[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

From: Christian Franke
Subject: Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu
Date: Mon, 14 Jan 2008 22:37:13 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070802 SeaMonkey/1.1.4

Marco Gerards wrote:
Christian Franke <...> writes:

Unlike the other GRUB2 utils, grub-emu uses the glibc extension
argp_parse(). It is unavailable on Cygwin, which might also be the
case for other platforms where glibc is not the native runtime.

This patch changes this back to the more traditional getopt_long().

It also fixes the syntax of the path prefix.

There where no objections, so I'll review this patch as promised.


How did you change the path syntax?

grub_util_get_grub_dev () returns e.g. "hd0,1", the resulting prefix is "hd0,1/boot/grub" but should be "(hd0,1)/boot/grub".

2007-11-10  Christian Franke  <address@hidden>

        * util/grub-emu.c: Replace argp.h by getopt.h.

Please use <argp.h> and <getopt.h> to show where it comes from.

        (parse_opt): Remove.

You also modified options, removed struct arguments, argp and perhaps
other things I missed.  You should document them properly in the
changelog entry.



2008-01-14  Christian Franke  <address@hidden>

        * util/grub-emu.c: Replace <argp.h> by <getopt.h>.
        (argp_program_version): Remove variable.
        (argp_program_bug_address): Likewise.
        (options): Convert from struct argp_option to struct option.
        (struct arguments): Remove.
        (parse_opt): Remove.
        (usage): New function.
        (main): Replace struct args members by simple variables.
        Replace argp_parse() by getopt_long().
        Add switch to evaluate options.
        Add missing "(...)" around root_dev in prefix string.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]