[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

From: Marco Gerards
Subject: Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu
Date: Sun, 13 Jan 2008 18:52:53 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Christian Franke <address@hidden> writes:

> Unlike the other GRUB2 utils, grub-emu uses the glibc extension
> argp_parse(). It is unavailable on Cygwin, which might also be the
> case for other platforms where glibc is not the native runtime.
> This patch changes this back to the more traditional getopt_long().
> It also fixes the syntax of the path prefix.

There where no objections, so I'll review this patch as promised.

How did you change the path syntax?

> 2007-11-10  Christian Franke  <address@hidden>
>       * util/grub-emu.c: Replace argp.h by getopt.h.

Please use <argp.h> and <getopt.h> to show where it comes from.

>       (parse_opt): Remove.

You also modified options, removed struct arguments, argp and perhaps
other things I missed.  You should document them properly in the
changelog entry.

>       (usage): New function.
>       (main): Replace argp_parse() by getopt_long().
>       Rename argument variables accordingly.
>       Add missing "(...)" for root_dev in prefix.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]