groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 01/05: [gropdf]: Skip a test if gs unavailable.


From: G. Branden Robinson
Subject: [groff] 01/05: [gropdf]: Skip a test if gs unavailable.
Date: Mon, 13 Feb 2023 14:15:28 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 2ff76bc40468394c7aed3e0209880cd2c490c961
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Feb 13 11:09:25 2023 -0600

    [gropdf]: Skip a test if gs unavailable.
    
    * font/devpdf/tests/basic-fonts-present.sh: Skip test if 'gs' command
      not available.  The test is to ensure that gropdf will produce sound
      documents using the base fonts from PostScript, but since gropdf
      requires Ghostscript to do this (as noted in our "./configure"
      messages), it makes no sense to validate font availability if the
      program is absent.  Resolves test failure seen on macOS with minimal
      dependencies installed.
---
 ChangeLog                                | 10 ++++++++++
 font/devpdf/tests/basic-fonts-present.sh |  8 ++++++++
 2 files changed, 18 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 6eec5b754..76f813c2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2023-02-13  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * font/devpdf/tests/basic-fonts-present.sh: Skip test if 'gs'
+       command not available.  The test is to ensure that gropdf will
+       produce sound documents using the base fonts from PostScript,
+       but since gropdf requires Ghostscript to do this (as noted in
+       our "./configure" messages), it makes no sense to validate font
+       availability if the program is absent.  Resolves test failure
+       seen on macOS with minimal dependencies installed.
+
 2023-02-12  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * doc/groff.texi (Manipulating Filling and Adjustment): Say more
diff --git a/font/devpdf/tests/basic-fonts-present.sh 
b/font/devpdf/tests/basic-fonts-present.sh
index 5b55ed5ef..b373dfc0f 100755
--- a/font/devpdf/tests/basic-fonts-present.sh
+++ b/font/devpdf/tests/basic-fonts-present.sh
@@ -23,6 +23,14 @@
 #
 # We need all of them except SS and ZDR.
 
+# Our configure script warns that gropdf will not be functional if gs
+# (Ghostscript) is not available.
+if ! command -v gs
+then
+    echo "gs command not available; skipping test" >&2
+    exit 77 # skip
+fi
+
 devps_fontsrcdir="${abs_top_srcdir:-..}"/font/devps
 devpdf_fontbuilddir="${abs_top_builddir:-.}"/font/devpdf
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]