Re: [PATCH] Fix DEVEL=1 build

[Mark H Weaver]

Hi Bill,

bill-auger <bill-auger@peers.community> writes:

> the bug was introduced in this commit, which added some language-specific
> configs to the 'files-to-append' directory
> https://git.savannah.gnu.org/cgit/gnuzilla.git/commit/?id=494f8c518598bfdd1596508e864a527ab677f3ea

I think the bug existed before that.  That commit added new localized
messages for the newly exposed 'resistFingerprinting' setting in
<about:preferences>.

> the effect seems to be that the 'resistFingerprinting' treatment will be
> applied only to that small set of languages

I think the only functionality that's missing from other languages
regarding 'resistFingerprinting' (and the other "IceCat-specific privacy
settings) are the localized strings for those languages.

> - im not sure what was the motivation for that;

Presumably that Ruben was able to translate the new IceCat-specific
messages into a small number of languages, but not all of them.

> but it should probably be done in the makeicecat script,
> to apply the change to all installed languages

I think it's already done.  It should be handled by this code in the
'apply_patches' shell function:

--8<---------------cut here---------------start------------->8---
    for dir in l10n/*; do
        if [[ $dir != l10n/compare-locales ]]; then
            if [[ ! -e ${DATADIR}/files-to-append/${dir}/${PREFS_OUT_FILE} ]]; 
then
                cat ${DATADIR}/files-to-append/${PREFS_IN_FILE} >> 
${dir}/${PREFS_OUT_FILE}
            fi
        fi
    done
--8<---------------cut here---------------end--------------->8---

This code aims to add the English-language messages for the
"IceCat-specific privacy settings" (including 'resistFingerprinting')
for all languages for which we don't yet have proper localized strings.

Am I mistaken?

      Thanks,
        Mark