Re: [PATCH 0/3] gnustep-make: stage 1 of cross-compile awareness

[Ladislav Michl]

On Tue, Jan 14, 2020 at 11:50:38AM +0100, Wolfgang Lux wrote:
> 
> > Am 13.01.2020 um 19:10 schrieb Ladislav Michl <address@hidden>:
> > 
> > On Mon, Jan 13, 2020 at 06:31:21PM +0100, Wolfgang Lux wrote:
> >> Hmmm, I guess you tried to include
> >>  MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[^0-9]*//')`
> >> just verbatim in configure.ac. That doesn't work because the square 
> >> brackets act as quote characters in M4 itself. So you need to properly 
> >> quote the regular expression like this:
> >>  MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[[^0-9]]*//')`
> >> You could of course quote the whole code instead:
> >>  [MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[^0-9]*//')`]
> > 
> > Nice catch! So you just found why is make detection broken in current
> > configure.ac, yet nobody cared :)
> 
> I’m a bit confused by that statement. Since I couldn’t remember having seen 
> any issues with gnustep-make any time recently, I checked the current version 
> of configure.ac and there all regular expression are properly quoted. I’m 
> afraid that you’ve introduced this issue yourself with your changes. :-(

Ah yes, and it is clearly visible even from last patch. All that happened
playing with resulting configure, rather than configure.ac, so quotation
got lost. Lets drop this patch then. Also, could you review others?

Thank you,
        ladis