[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] gnustep-make: stage 1 of cross-compile awareness

From: Wolfgang Lux
Subject: Re: [PATCH 0/3] gnustep-make: stage 1 of cross-compile awareness
Date: Tue, 14 Jan 2020 11:50:38 +0100

> Am 13.01.2020 um 19:10 schrieb Ladislav Michl <address@hidden>:
> On Mon, Jan 13, 2020 at 06:31:21PM +0100, Wolfgang Lux wrote:
>> Hmmm, I guess you tried to include
>>  MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[^0-9]*//')`
>> just verbatim in That doesn't work because the square brackets 
>> act as quote characters in M4 itself. So you need to properly quote the 
>> regular expression like this:
>>  MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[[^0-9]]*//')`
>> You could of course quote the whole code instead:
>>  [MAKE_VERSION=`(${GNUMAKE} --version | head -1 | sed -e 's/^[^0-9]*//')`]
> Nice catch! So you just found why is make detection broken in current
>, yet nobody cared :)

I’m a bit confused by that statement. Since I couldn’t remember having seen any 
issues with gnustep-make any time recently, I checked the current version of and there all regular expression are properly quoted. I’m afraid 
that you’ve introduced this issue yourself with your changes. :-(


reply via email to

[Prev in Thread] Current Thread [Next in Thread]