Re: [Gnumed-bugs] Fwd: [Gnumed-devel] GNUmed 1.5.0 Feature Release - inbox shows *old* unsigned documents

[Karsten Hilbert]

On Wed, Jan 21, 2015 at 05:44:01PM +0000, Jim Busser wrote:

> While the following might be the result of a bug-fix or other enhancement to 
> GNUmed's logic, I figured I would report it …

Absolutely !

> When I upgraded my deployed (production) system from GNUmed 1.4.8 to 1.5.2, 
> my inbox grew the items shown in Screen Shot 1.
> 
> The first line item pertains to an actual patient whose real name I have 
> replaced by a pseudonym (Beenthere, Alice) whose
> 
> '3 unreviewed documents'
> 
> turn out to have been created between May and August of 2011. SInce I am 
> pretty sure I have often fully cleared out my production inbox, I am at a 
> loss to understand why these are now showing up as needing signing unless I 
> had never actually signed them and the reason that they now appear is a 
> result of a patch or improvement to GNUmed's code such that it had previously 
> missed to catch some unreviewed documents (perhaps something about their 
> state?).
> 
> Any chance that this was the case, perhaps even implemented in a minor 
> release > 1.4.8 but which is not noted in the 1.5.0 release?

Certainly possible as I have rewritten that part of the inbox
view. Here's the relevant commit, as usual, reported by yours
truly :-)

 commit fea58248880fd05c43522a4fef88f38c803e9632
 Author: Karsten Hilbert <address@hidden>
 Date:   Mon Dec 22 20:59:16 2014 +0100

    Improve new-documents virtual inbox message.

        A field report hinted at the possibility of the inbox
        not showing a hint towards unreviewed documents for a
        patient. I haven't been able to find out why (as I can't
        inspect the live database) but I have rewritten the part
        of dem.v_message_inbox related to unreviewed documents
        which should now be easier to dig down into should the
        issue reappear. On the upside we gain an indicator of
        exactly how many documents are pending review.
        Reported by Jim.

As for where:

~/Projekte/gm-git/gnumed/gnumed$ git branch --contains 
fea58248880fd05c43522a4fef88f38c803e9632
* master
  rel-1-5-patches

What's truly interesting: Did this patient, in fact, have 3
unreviewed documents ?

> 1) is it expected that the "Sent" date shows today, by

yes

> virtue of this fresh loading of the inbox with virtual items,
> rather than the date (oldest or newest) of any of the
> documents themselves?

For the blink of an eye I considered doing that but it's
non-trivial so I figured more pain than gain.

Karsten
-- 
GPG key ID E4071346 @ eu.pool.sks-keyservers.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346