gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] Remove some unnecessary #ifndef WIN32


From: Pawel Kot
Subject: Re: [PATCH 3/8] Remove some unnecessary #ifndef WIN32
Date: Mon, 3 Dec 2018 20:18:12 +0300

Hi,

On Mon, Dec 3, 2018 at 7:49 PM Ladislav Michl <address@hidden> wrote:
>
> Hi Paweł,
>
> On Mon, Dec 03, 2018 at 06:15:07PM +0300, Pawel Kot wrote:
> > Hi,
> >
> > On Mon, Dec 3, 2018 at 12:41 PM Ladislav Michl <address@hidden> wrote:
> > > diff --git a/gnokii/gnokii-calendar.c b/gnokii/gnokii-calendar.c
> > > index e32bf769..10236bae 100644
> > > --- a/gnokii/gnokii-calendar.c
> > > +++ b/gnokii/gnokii-calendar.c
> > > @@ -264,7 +264,6 @@ gn_error writecalendarnote(int argc, char *argv[],
> > gn_data *data, struct gn_stat
> > > -#ifndef WIN32
> > >                 if (error == GN_ERR_NOTIMPLEMENTED) {
> > >                         switch (gn_vcal_file_event_read(optarg, &calnote,
> > i)) {
> >
> > Probably excluding it for all WIN32 platforms is excessive, but
> > gn_vcal_file_event_read() is generated by flex, which is missing on native
> > Windows platforms. I'm fine with changing it but it will fail on Visual
> > Studio platforms.
>
> Which leads to a question whenever flex output should be part of source
> tarball. Developers working on git version should be smart enough to setup
> their envinroment properly.

Yes, we had this discussion some time ago. The conclusion was that in git tree we do not keep it, but we put it into a source tarball. Still, I'm not sure if it would compile under Windows.

Cheers,
Paweł
--
Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]