Re: [PATCH 2/8] Use lower case for Win32 includes

[Fabrizio Gennari]

Il 03-12-18 16:10, Pawel Kot ha scritto:

Hi,

On Mon, Dec 3, 2018 at 12:42 PM Ladislav Michl <address@hidden> wrote:
> diff --git a/include/gnokii.h.in b/include/gnokii.h.in
> index b3253455..d407d53d 100644
> --- a/include/gnokii.h.in
> +++ b/include/gnokii.h.in
> @@ -31,8 +31,8 @@ extern "C" {

[...]
> -#elif defined(_MSC_VER) && defined(WIN32)

[...]
> +#elif defined(WIN32)

So this one changes behaviour and is not explained. And not sure if correct. Care to give an explanation?

This fixes a compilation error on MinGW32 about struct timeval not being defined

i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../include    -I../include -g -O2 -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing  -MT dump_vcard-dump-vcard.o -MD -MP -MF .deps/dump_vcard-dump-vcard.Tpo -c -o dump_vcard-dump-vcard.o `test -f 'dump-vcard.c' || echo './'`dump-vcard.c
In file included from ../include/gnokii.h:63:0,
                 from dump-vcard.c:4:
../include/gnokii/common.h:775:17: error: field ‘last’ has incomplete type
  struct timeval last;
                 ^~~~
In file included from ../include/gnokii/data.h:22:0,
                 from ../include/gnokii.h:64,
                 from dump-vcard.c:4:
../include/gnokii/call.h:70:17: error: field ‘start_time’ has incomplete type
  struct timeval start_time;
                 ^~~~~~~~~~
../include/gnokii/call.h:71:17: error: field ‘answer_time’ has incomplete type
  struct timeval answer_time;
                 ^~~~~~~~~~~