[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

buglet in atgen.c?

From: Osma Suominen
Subject: buglet in atgen.c?
Date: Wed, 11 Jun 2003 22:05:07 +0300 (EEST)


I noticed a strangeness in atgen code, where sm_wait_for is called in an
unusual way. I think sm_block_no_retry should be called instead.
Attached is a patch that corrects it, but I can't test it because I
don't have an AT-capable phone. Since this relates to error handling the
bug probably doesn't show up very often.


Index: atgen.c
RCS file: /cvsroot/gnokii/gnokii/common/phones/atgen.c,v
retrieving revision 1.83
diff -u -r1.83 atgen.c
--- atgen.c     26 Feb 2003 10:05:30 -0000      1.83
+++ atgen.c     11 Jun 2003 19:01:29 -0000
@@ -572,7 +572,7 @@
        dprintf("%s", req);
        if (sm_message_send(strlen(req), GN_OP_CallDivert, req, state))
                return GN_ERR_NOTREADY;
-       return sm_wait_for(GN_OP_CallDivert, data, state);
+       return sm_block_no_retry(GN_OP_CallDivert, data, state);

 static gn_error AT_SetPDUMode(gn_data *data, struct gn_statemachine

*** Osma Suominen *** address@hidden *** ***

reply via email to

[Prev in Thread] Current Thread [Next in Thread]