Re: Add sm_block_ack() to statemachine?

[BORBELY Zoltan]

Hi,

On Mon, Jun 02, 2003 at 11:52:41PM +0300, Osma Suominen wrote:
> * Places where sm_message_send is called without sm_block* following

[...]

> nk6100.c:1005 (auth code doesn't check return msg)

It seems the phone won't respond to the magic_connect message (see
Docs/protocol/nk6110.txt).

> nk6100.c:2985,2992,2995,3001,3004,3009 (making calls, check return msg later)
> nk6100.c:3028 (answer call; return msg for 1st of 2 msgs not checked)

This call handling stuff in the nk6100 driver is quite fragile. The first
version was more perfect, but didn't work. :-) After a lot of testing we
removed a lot of sm_block and added usleep calls into it. Currently it
works but it's some kind of woodoo magic.

> nk6100.c:3639 (NBSupload does't check return msg)

If I remember correctly this message won't send any reply.

[...]

> * Places where sm_block* is called not immediately after sm_message_send
> 
> nk6100.c:3018 (making calls; return msg only checked after several msgs)

Black art.

Bye,
Bozo