gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A bug and sorta a fix


From: Tor Petterson
Subject: Re: A bug and sorta a fix
Date: Tue, 27 Aug 2002 15:36:05 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020623 Debian/1.0.0-0.woody.1

Pawel Kot wrote:
Well, this loop doesn't look sane for me. See the attached patch. I'm not
commiting it because I'm not sure whether it is correct and whether it
works. Please test. Anyway it won't fix the connection per se, it will
just not attempt to reconnect.

the pacth just moved the problem to somewhere else.
but the included patch fixes the problem for me. If you compare lines 508-511 in nk6100.c to lines 390-392 in nk6510.c you see where the problem comes from

Tor
--- xgnokii_lowlevel.c.orig     2002-08-27 01:43:17.000000000 +0200
+++ xgnokii_lowlevel.c  2002-08-27 15:17:11.000000000 +0200
@@ -253,10 +253,9 @@
 
        /* Initialise the code for the GSM interface. */
 
-       if (error == GE_NOLINK)
-               error = gn_gsm_initialise(xgnokiiConfig.model, 
xgnokiiConfig.port,
-                                         xgnokiiConfig.initlength, connection, 
RLP_DisplayF96Frame,
-                                         &statemachine);
+       error = gn_gsm_initialise(xgnokiiConfig.model, xgnokiiConfig.port,
+                                 xgnokiiConfig.initlength, connection, 
RLP_DisplayF96Frame,
+                                 &statemachine);
 
 #ifdef XDEBUG
        g_print("fbusinit: error %d\n", error);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]