[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A bug and sorta a fix

From: Pawel Kot
Subject: Re: A bug and sorta a fix
Date: Tue, 27 Aug 2002 17:32:29 +0200

>>> address@hidden 27 August 2002 15:36:05 >>>
> Pawel Kot wrote:
> > Well, this loop doesn't look sane for me. See the attached patch. I'm not
> > commiting it because I'm not sure whether it is correct and whether it
> > works. Please test. Anyway it won't fix the connection per se, it will
> > just not attempt to reconnect.
> the pacth just moved the problem to somewhere else.

What problem?

> but the included patch fixes the problem for me.

Your patch is just a part of the patch I sent. I don't think we need a loop. 
gnokii does
just a single try. Did you bother to look/apply the patch I sent?

> If you compare lines 508-511 in nk6100.c to lines 390-392 in
> nk6510.c you see where the problem comes from

No. This is othogonal. I think we should return err instead of GE_NOTSUPPORTED 
nk6100.c. But this is irrelevant for the real problem.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]