[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Additional feature for SMSD

From: Michael Meier
Subject: Re: Additional feature for SMSD
Date: Wed, 7 Aug 2002 16:43:31 +0200

Hi jano,

> The code is not well tested. Please test it.

Done :) It's working great.
I wrote a little php script which takes input and writes it to a file..
no problems, working on first try.
Sending SMS by using the spool folder works perfect, too.

What is missing are some checks for valid input:
1) Action: a check if the action file exists would be good to prevent
loss of incoming sms by a typo in action name. (Message+Quit if not

2) Spool-Directory: if the spool directory does not exist (and same if
no permissions are given i guess) it fails to open it ("Cannot open
directory ...") but keeps trying every couple of seconds.
Best thing would probably also be a Message+Quit on startup and on first
occurance (e.g. if someone deletes the folder while smsd is running)

3) Spool-File Format:
If the spool file is invalid due to format errors, it prints 4 times
event 0 failed and then a cannot send sms from path/file. To prevent
smsd from slowing down or locking up due to too many invalid files there
it would be better to print a warning to console or errorlog and delete
the file as it keeps on trying to send the sms.

I tried different scenarios but was not able to find any bug, so all i
can say is:
Great work! Thanks a lot! :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]