[Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/MovieClip.getURL() on `undefined` and `null` target

[Nutchanon Wetchasit]

Follow-up Comment #5, patch #9279 (project gnash):

Patch 6 of 6:
See the attached `0006_geturl-add-weird-target-tests.patch`.

This patch adds automated checks non-FSCommand usage of `getURL()` and
`MovieClip.getURL()` when encountered with weird target parameter like empty
"", `null`, and `undefined` to Gnash testsuite; according to reference
behavior listed on bug #50393 comment 1
<https://savannah.gnu.org/bugs/?50393#comment1>.

Implementation notes:

* This test is based on MakeSWF, and run under shell-based container emulation
environment, with external termination (much like the `hostcmd` test).
* This test runs on SWF version 4 to 8 as `getURL()` is available since Flash
4 onward- according to Macromedia's documentation.
* I implemented this as a separate test runner from `hostcmd` as it cannot be
run under the same HTML-mode container.
* There's no XFAILED check, as problems are already fixed by earlier
<https://savannah.gnu.org/patch/?9279#comment1> patches
<https://savannah.gnu.org/patch/?9279#comment2>.

This patch does not provide HTML-based test runner, as it is beyond limit of
what simple semi-automated HTML test page could do. Also, implementing the
test even in semi-automated fashion would require another exotic Flash feature
(FlashVars), which must be tested first.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39894)
    _______________________________________________________

Additional Item Attachment:

File name: 0006_geturl-add-weird-target-tests.patch Size:15 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9279>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/