[Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/MovieClip.getURL() on `undefined` and `null` target

[Nutchanon Wetchasit]

Follow-up Comment #2, patch #9279 (project gnash):

Patch 3 of 6:
See the attached `0003_correct-builtin-geturl-undefined-null-target.patch`.

Current Gnash treats `undefined` and `null` target parameter in built-in
`getURL()` function as if they were empty string
<https://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/vm/ASHandlers.cpp?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n3524>.

Flash Player, other the other hand, uses (SWF version-specific) string
representation of the parameter
<https://savannah.gnu.org/bugs/?50393#comment1> as target. This behavior is
the same in both normal and FSCommand usage.

This patch fixes Gnash implementation by replacing the special case treatment
with SWF version-specific string conversion.

Corresponding 4 XFAILED check in Gnash testsuite are changed to PASSED in this
patch; resulting in 16 more PASSED checks total when counted all SWF version
and test method. (8 more PASSED in automated run, 8 more PASSED in
browser-based run)

Side note (for the record):
MakeSWF processes `getURL("loaded.html")` into ActionGetURL2 instruction that
looks more or less like `getURL("loaded.html","")`. Macromedia Flash MX 2004
also processes the call into a similar statement, though it uses an old-school
ActionGetURL instead of ActionGetURL2.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Adobe Flash Player: 11.2.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39891)
    _______________________________________________________

Additional Item Attachment:

File name: 0003_correct-builtin-geturl-undefined-null-target.patch Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9279>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/