[Gnash-commit] [patch #8993] Patches to fix problems when `--disable-media` configure option was used

[Nutchanon Wetchasit]

Follow-up Comment #6, patch #8993 (project gnash):

For the compiler warning <https://savannah.gnu.org/patch/?8993#comment5>,
thanks for pointing that out; definitely a good idea to include it in the fix
since it is related to `USE_MEDIA` code exclusion. Maybe I didn't stumble on
it because it didn't cause an immediate build problem.

But for the operator issue <https://savannah.gnu.org/patch/?8993#comment4>: If
the MediaParser parts of the first patch are omitted, the build results in
link error on my machine:

../libcore/.libs/libgnashcore.so: undefined reference to
`gnash::media::operator<<(std::ostream&, gnash::media::audioCodecType
const&)'
collect2: error: ld returned 1 exit status
make[4]: *** [gtk-gnash] Error 1
make[4]: Leaving directory `/home/window/prog/gnash.git/gui'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/window/prog/gnash.git/gui'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/window/prog/gnash.git/gui'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/window/prog/gnash.git'
make: *** [all] Error 2


The linker command in my case (run in `gui` subfolder) was:

ccache g++ 
        -g -O2 -std=c++11 -W -Wall -Wcast-qual -Wpointer-arith -Wreturn-type
-Wnon-virtual-dtor -Wunused 
        -fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security 
        -fstack-protector --param ssp-buffer-size=4 
        -Wl,--as-needed -fPIE -pie 
        -Wl,-z -Wl,relro -Wl,-z -Wl,now 
        -o .libs/gtk-gnash 
        gtk_gnash-gnash.o gtk_gnash-gui.o gtk_gnash-Player.o gtk_gnash-NullGui.o
gtk_gnash-ScreenShotter.o gtk_gnash-gtk_canvas.o gtk_gnash-gtk.o
gtk_gnash-gui_gtk.o gtk_gnash-gtk_glue_agg.o 
        -Wl,--export-dynamic 
        ../libcore/.libs/libgnashcore.so ../libdevice/.libs/libgnashdevice.so
../librender/.libs/libgnashrender.so ../libbase/.libs/libgnashbase.so
../libsound/.libs/libgnashsound.so 
        -lgtk-x11-2.0 -lgdk-x11-2.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0
-lgdk_pixbuf-2.0 
        /usr/lib/i386-linux-gnu/libcairo.so 
/usr/lib/i386-linux-gnu/libfreetype.so 
        -lfontconfig -lpangox-1.0 -lpango-1.0 -latk-1.0 -lgobject-2.0 
-lglib-2.0 
        /usr/lib/i386-linux-gnu/libexpat.so 
        -L/usr/lib/i386-linux-gnu 
        -lX11 -lXinerama -lXext -lSM -lICE -lboost_program_options-mt -lagg_pic 
-lrt

        -Wl,-rpath -Wl,/usr/local/lib/gnash


I have tried listing all `media::operator` symbol in the build tree to find
potential implementation and found none; all of them are unresolved ("U")
symbol:

$ find -name '*.so' -o -name '*.o' | xargs -d \n -L 1 sh -c 'nm -gC $0 | xargs
-L 1 -d \n echo $0:' | grep media::operator
./libcore/.libs/libgnashcore.so:          U
gnash::media::operator<<(std::ostream&, gnash::media::audioCodecType const&)
./libcore/.libs/tag_loaders.o:          U
gnash::media::operator<<(std::ostream&, gnash::media::audioCodecType const&)
./libcore/.libs/libgnashcore-0.8.11dev.so:          U
gnash::media::operator<<(std::ostream&, gnash::media::audioCodecType const&)
./libcore/.libs/SoundStreamHeadTag.o:          U
gnash::media::operator<<(std::ostream&, gnash::media::audioCodecType const&)
$ 


>From the command output, it looks like that `ostream << media::audioCodecType`
is implmented only in libgnashmedia (which is unavailable when using
`--disable-media` build flag).

Gnash: 0.8.11dev (patched against git 484ca4c 29-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8993>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/