[Gnash-commit] [patch #8993] Patches to fix problems when `--disable-media` configure option was used

[Sandro Santilli]

Follow-up Comment #5, patch #8993 (project gnash):

Another issue is this warning:

/usr/src/gnash/gnash-head/libcore/asobj/NetStream_as.cpp:198:1: warning: no
return statement in function returning non-void [-Wreturn-type]
 }
 ^
which can be fixed with this:

diff --git a/libcore/asobj/NetStream_as.cpp b/libcore/asobj/NetStream_as.cpp
index d500ea0..06dec58 100644
--- a/libcore/asobj/NetStream_as.cpp
+++ b/libcore/asobj/NetStream_as.cpp
@@ -194,6 +194,8 @@ NetStream_as::bufferLength()
 #ifdef USE_MEDIA
     if (_parser.get() == nullptr) return 0;
     return _parser->getBufferLength();
+#else
+    return 0;
 #endif  // USE_MEDIA
 }


I checked, and the output operator could probably just remain in
MediaParser.cpp, why did you feel the need to move it ?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8993>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/