Re: [Gnash-commit] /srv/bzr/gnash/trunk r12163: implemented most of the methods used by the ExternalInterface AS class.

[Benjamin Wolsey]

> > Even works in progress shouldn't contain some of the errors I pointed
> > out. Nevertheless, getting an early code review will save you from
> > wasting time by continuing to do the wrong thing in those places,
> > provided you take the time to understand what I wrote.
> 
>   I'm gonna ignore the insult, your PHD doesn't mean anything to me. I
> have little interest in yet another flame war. Other people asked me to
> migrate these changes to trunk for them. Just cause you won't get near
> any code I write doesn't mean others feel the same way.

There was no insult there. I'm talking about paying care and attention,
and not fobbing off reviews with silly emails.

If I take the time to read and review your code, it's a bit
disheartening to get a reply saying "you're welcome to fix it up" or "in
case you hadn't noticed". That doesn't suggest to me that you're taking
my effort seriously, or that you have bothered to read and understand
the criticisms.

It's particularly important that you do, because I pointed out some
serious and obvious coding errors, which will cause "instability" with
the slightest change by you, or indeed anyone else who wants to work on
this code.

>   Unless we work on functionality that others will actually use, we'll
> never have funding again. It's great fun to work on a free software
> project, but some of us would like to also get funded again.

No one has said that what you're working on isn't useful. On the
contrary, it is exactly the sort of thing that's needed. But it's only
really useful once the major bugs are ironed out, which is what a review
is intended to help achieve.

bwy


--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog

xmpp:address@hidden
http://identi.ca/bwy

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil