Re: [Gnash-commit] /srv/bzr/gnash/trunk r12163: implemented most of the methods used by the ExternalInterface AS class.

[Rob Savoye]

On 04/21/10 07:52, Benjamin Wolsey wrote:

> I won't fix up your code. I expect you to read my code review and act on
> it. You should fix your own bugs in a reasonable space of time, like
> everyone else who commits to Gnash.

  I didn't ask you to fix the code. I read your review, I'll get around
to it later. Considering that none of this code even gets used by
anything but a single test case, I think there isn't much to worry
about. All the code it replaced was stubs, and a test case where all the
tests failed.

> Even works in progress shouldn't contain some of the errors I pointed
> out. Nevertheless, getting an early code review will save you from
> wasting time by continuing to do the wrong thing in those places,
> provided you take the time to understand what I wrote.

  I'm gonna ignore the insult, your PHD doesn't mean anything to me. I
have little interest in yet another flame war. Other people asked me to
migrate these changes to trunk for them. Just cause you won't get near
any code I write doesn't mean others feel the same way.

  Unless we work on functionality that others will actually use, we'll
never have funding again. It's great fun to work on a free software
project, but some of us would like to also get funded again.

        - rob -