[Gnash-commit] gnash server/as_value.cpp testsuite/actionscrip...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/04/19 18:58:46

Modified files:
        server         : as_value.cpp 
        testsuite/actionscript.all: MovieClip.as 
        .              : ChangeLog 

Log message:
                * server/as_value.cpp (equals): comment out debugging line.
                * testsuite/actionscript.all/MovieClip.as: 
                  our soft references are bogus !! more tests for it.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.cpp?cvsroot=gnash&r1=1.43&r2=1.44
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/MovieClip.as?cvsroot=gnash&r1=1.59&r2=1.60
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2940&r2=1.2941

Patches:
Index: server/as_value.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.cpp,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -b -r1.43 -r1.44
--- server/as_value.cpp 19 Apr 2007 17:06:46 -0000      1.43
+++ server/as_value.cpp 19 Apr 2007 18:58:45 -0000      1.44
@@ -624,7 +624,7 @@
 bool
 as_value::equals(const as_value& v, as_environment* env) const
 {
-    log_msg("equals(%s, %s) called", to_debug_string().c_str(), 
v.to_debug_string().c_str());
+    //log_msg("equals(%s, %s) called", to_debug_string().c_str(), 
v.to_debug_string().c_str());
 
     bool this_nulltype = (m_type == UNDEFINED || m_type == NULLTYPE);
     bool v_nulltype = (v.get_type() == UNDEFINED || v.get_type() == NULLTYPE);

Index: testsuite/actionscript.all/MovieClip.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/MovieClip.as,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -b -r1.59 -r1.60
--- testsuite/actionscript.all/MovieClip.as     19 Apr 2007 18:44:52 -0000      
1.59
+++ testsuite/actionscript.all/MovieClip.as     19 Apr 2007 18:58:45 -0000      
1.60
@@ -22,7 +22,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: MovieClip.as,v 1.59 2007/04/19 18:44:52 strk Exp $";
+rcsid="$Id: MovieClip.as,v 1.60 2007/04/19 18:58:45 strk Exp $";
 
 #include "check.as"
 
@@ -274,10 +274,18 @@
 check_equals(mc4._target, "/mc4_mc");
 var mc5 = mc4.createEmptyMovieClip("mc5_mc", 60);
 check_equals(mc5._target, "/mc4_mc/mc5_mc");
+check_equals(typeof(mc4_mc), 'movieclip');
+check_equals(typeof(mc4_mc.mc5_mc), 'movieclip');
+check_equals(typeof(mc4), 'movieclip');
+check_equals(typeof(mc5), 'movieclip');
 mc4._name = 'changed'; 
-check_equals(mc4._target, "/changed");
-check_equals(mc5._target, "/changed/mc5_mc");
-check_equals(mc5._parent, mc4);
+check_equals(typeof(mc4_mc), 'undefined');
+check_equals(typeof(mc4_mc.mc5_mc), 'undefined');
+check_equals(typeof(mc4), 'movieclip');
+check_equals(typeof(mc5), 'movieclip');
+// gah.. our "soft references" are bogus :(
+xcheck_equals(mc4._target, "/changed");
+xcheck_equals(mc5._target, "/changed/mc5_mc");
 #endif
 
 //--------------------------------------------------------------------------

Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2940
retrieving revision 1.2941
diff -u -b -r1.2940 -r1.2941
--- ChangeLog   19 Apr 2007 18:44:51 -0000      1.2940
+++ ChangeLog   19 Apr 2007 18:58:45 -0000      1.2941
@@ -1,7 +1,9 @@
 2007-04-19 Sandro Santilli <address@hidden>
 
+       * server/as_value.cpp (equals): comment out debugging line.
        * testsuite/actionscript.all/MovieClip.as: check that
          changing a _parent._name changes own _target.
+         WARNING: our soft references are bogus !!
 
 2007-04-19 Udo Giacomozzi <address@hidden>