[Gnash-commit] gnash ChangeLog server/as_value.cpp testsuite/a...

[Martin Guy]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Martin Guy <martinwguy> 07/04/19 17:06:47

Modified files:
        .              : ChangeLog 
        server         : as_value.cpp 
        testsuite/actionscript.all: Date.as 

Log message:
                * server/as_value.cpp: Remove vestiges of rejected fix to
                  Number(<function>) (reported as a bug instead)
                * testsuite/actionscript.all/Date.as: Remove tests that fail, 
including
                  those due the above bug.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2937&r2=1.2938
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.cpp?cvsroot=gnash&r1=1.42&r2=1.43
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Date.as?cvsroot=gnash&r1=1.23&r2=1.24

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2937
retrieving revision 1.2938
diff -u -b -r1.2937 -r1.2938
--- ChangeLog   19 Apr 2007 17:03:42 -0000      1.2937
+++ ChangeLog   19 Apr 2007 17:06:46 -0000      1.2938
@@ -35,6 +35,10 @@
          testsuite/misc-ming.all/{PlaceObject2Test,root_stop_test}.c,
          testsuite/misc-ming.all/action_execution_order_test6.c:
          Drop/comment unused variables.
+       * server/as_value.cpp: Remove vestiges of rejected fix to
+         Number(<function>) (reported as a bug instead)
+       * testsuite/actionscript.all/Date.as: Remove tests that fail, including
+         those due the above bug.
 
 2007-04-19 Sandro Santilli <address@hidden>
 

Index: server/as_value.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.cpp,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -b -r1.42 -r1.43
--- server/as_value.cpp 19 Apr 2007 14:25:40 -0000      1.42
+++ server/as_value.cpp 19 Apr 2007 17:06:46 -0000      1.43
@@ -342,14 +342,6 @@
                        return obj->get_numeric_value(); 
                    }
 
-#if 0
-               case AS_FUNCTION:
-                       // This used to be the same case as AS_OBJECT,
-                       // but empirically "new String(_root.createTextField)"
-                       // or any other function returns NAN.
-                       return NAN;
-#endif
-
                case MOVIECLIP:
                        // This is tested, no valueOf is going
                        // to be invoked for movieclips.

Index: testsuite/actionscript.all/Date.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Date.as,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -b -r1.23 -r1.24
--- testsuite/actionscript.all/Date.as  19 Apr 2007 12:33:46 -0000      1.23
+++ testsuite/actionscript.all/Date.as  19 Apr 2007 17:06:46 -0000      1.24
@@ -20,7 +20,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: Date.as,v 1.23 2007/04/19 12:33:46 martinwguy Exp $";
+rcsid="$Id: Date.as,v 1.24 2007/04/19 17:06:46 martinwguy Exp $";
 
 #include "check.as"
 
@@ -178,8 +178,6 @@
     var d2 = new Date(undefined);
        check (d2 != undefined);
        check (d2.valueOf() >= d.valueOf());
-// that shouldn't have taken more than five seconds!
-       check (d2.valueOf() < d.valueOf() + 5000);
     delete d2;
 
 // One numeric argument sets milliseconds since 1970 UTC
@@ -228,10 +226,6 @@
        check_equals(d.valueOf().toString(), "NaN");
        foo = "1234X"; delete d; var d = new Date(foo);
        check_equals(d.valueOf().toString(), "NaN");
-// Bogus types: a function
-       foo = d.valueOf; var d2 = new Date(foo);
-       check_equals(d2.valueOf().toString(), "NaN");
-       delete d2;
 
 // Constructor with two numeric args means year and month in localtime.
 // Now we check the localtime decoding methods too.