Re: [Gnash-commit] gnash ChangeLog server/as_value.h server/as_val...

[strk]

On Thu, Apr 19, 2007 at 02:26:32PM +0200, strk wrote:
> On Thu, Apr 19, 2007 at 12:06:57PM +0000, Martin Guy wrote:
> > CVSROOT:    /sources/gnash
> > Module name:        gnash
> > Changes by: Martin Guy <martinwguy> 07/04/19 12:06:56
> > 
> > Modified files:
> >     .              : ChangeLog 
> >     server         : as_value.h as_value.cpp edit_text_character.cpp 
> >     server/vm      : ASHandlers.cpp 
> > 
> > Log message:
> >     Always do version-dependent conversion to string, and move version
> >     detection for this to a single point in the lowest level. 
> >     This also eliminates all *_versioned() string methods.
> 
> Please stop committing w/out running make check !
> 
> FAIL: run_swfdec_testsuite: and-or-5.swf (traces in and-or-5.swf.trace-gnash, 
> log in and-or-5.swf.log)
> FAIL: run_swfdec_testsuite: and-or-6.swf (traces in and-or-6.swf.trace-gnash, 
> log in and-or-6.swf.log)
> FAIL: run_swfdec_testsuite: and-or-7.swf (traces in and-or-7.swf.trace-gnash, 
> log in and-or-7.swf.log)
> FAIL: run_swfdec_testsuite: constructor-prototype.swf (traces in 
> constructor-prototype.swf.trace-gnash, log in constructor-prototype.swf.log)
> FAIL: run_swfdec_testsuite: divide-7.swf (traces in divide-7.swf.trace-gnash, 
> log in divide-7.swf.log)
> FAIL: run_swfdec_testsuite: empty-stack.swf (traces in 
> empty-stack.swf.trace-gnash, log in empty-stack.swf.log)
> FAIL: run_swfdec_testsuite: undefined-tostring.swf (traces in 
> undefined-tostring.swf.trace-gnash, log in undefined-tostring.swf.log)
> FAIL: run_swfdec_testsuite: undefined2-6.swf (traces in 
> undefined2-6.swf.trace-gnash, log in undefined2-6.swf.log)

And these are from actionscript.all:

FAIL: astests-v5-Runner: expected: "NaN" obtained: 0 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:197]
FAIL: astests-v5-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:163]
FAIL: astests-v5-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:186]
FAIL: astests-v5-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:381]
FAIL: astests-v5-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:382]
FAIL: astests-v5-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:390]
FAIL: astests-v5-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:391]
FAIL: astests-v5-Runner: expected: "two[object Object]" obtained: two[type 
Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:230]
FAIL: astests-v5-Runner: expected: "twoone" obtained: two[type Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:235]

FAIL: astests-v6-Runner: expected: "NaN" obtained: 0 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:197]
FAIL: astests-v6-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:163]
FAIL: astests-v6-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:186]
FAIL: astests-v6-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:381]
FAIL: astests-v6-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:382]
FAIL: astests-v6-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:390]
FAIL: astests-v6-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:391]
FAIL: astests-v6-Runner: expected: "two[object Object]" obtained: two[type 
Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:230]
FAIL: astests-v6-Runner: expected: "twoone" obtained: two[type Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:235]

FAIL: astests-v7-Runner: d2.valueOf() < d.valueOf() + 5000 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:146]
FAIL: astests-v7-Runner: expected: "NaN" obtained: 0 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:197]
FAIL: astests-v7-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:163]
FAIL: astests-v7-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:186]
FAIL: astests-v7-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:381]
FAIL: astests-v7-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:382]
FAIL: astests-v7-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:390]
FAIL: astests-v7-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:391]
FAIL: astests-v7-Runner: expected: "two[object Object]" obtained: two[type 
Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:230]
FAIL: astests-v7-Runner: expected: "twoone" obtained: two[type Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:235]

FAIL: astests-v8-Runner: d2.valueOf() < d.valueOf() + 5000 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:146]
FAIL: astests-v8-Runner: expected: "NaN" obtained: 0 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Date.as:197]
FAIL: astests-v8-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:163]
FAIL: astests-v8-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:186]
FAIL: astests-v8-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:381]
FAIL: astests-v8-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:382]
FAIL: astests-v8-Runner: expected: "-" + pi_2s obtained: -1.5707963267949 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:390]
FAIL: astests-v8-Runner: expected: "-" + pi_4s obtained: -0.785398163397448 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/Math.as:391]
FAIL: astests-v8-Runner: expected: "two[object Object]" obtained: two[type 
Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:230]
FAIL: astests-v8-Runner: expected: "twoone" obtained: two[type Object] 
[/home/strk/src/gnash/gnash-head/testsuite/actionscript.all/String.as:235]

Should I fix this time too or will you ?

--strk;