Re: [Gap-dev-discuss] Cynthiune build failure

[Philippe Roussel]

Hi,

Le 29/04/2012 17:29, Sebastian Reitenbach a écrit :
>  Hi Philippe,
> 
> On Thursday, April 26, 2012 16:32 CEST, Philippe Roussel <address@hidden> 
> wrote: 
>  
>> Le 26/04/2012 16:13, Sebastian Reitenbach a écrit :
>>>> Yeah, sorry I didn't try that first. With the attached WindowMedia patch
>>>> the bundle builds. It then fails in the MusePack bundle but is fixed
>>>
>>>> with the Musepack-new-API patch.
>>>
>>> Which version of libmpcdec do you have installed. The Musepack Bundle works 
>>> for me.
>>> I guess we have something different here. I have: libmpcdec-1.2.6 installed.
>>
>> The library is called libmpcdec6 and comes from a bigger package
>> containing multiple librairies called libmpcs. libmpcdec version seems
>> to be 1.3.0, from its changelog :
> 
> I applied the WindowsMedia patch as is, and made linking the OSS output
> bundle against libossaudio only on OpenBSD. I took the Musepack patch, and
> massaged it with a couple of #ifdefs to be able to build against "old" 
> Musepack
> API and the new one. The new API is the default. To build against the old
> one, you have to put ADDITIONAL_OBJCFLAGS=-DMUSEPACK_API_126 in
> the make environment like this:
> 
> ADDITIONAL_OBJCFLAGS=-DMUSEPACK_API_126 gmake install
> 
> Further I removed this old GNUSTEP_iNSTALLATION_DIR thingie from the 
> main GNUmakefile.
> 
> can you check how Cynthiune from CVS now works for you?

Well, it gets further :o)

With the following patch (maybe a configure script will be needed ?), I
can run 'make disable-arts=yes' but linking fails with :

>  Linking app Cynthiune ...
> ./obj/Cynthiune.obj/CynthiuneController.m.o:(.data.rel+0x4): undefined 
> reference to `__objc_class_name_MailService'
> ./obj/Cynthiune.obj/PlaylistController.m.o: In function `-[PlaylistController 
> _feedPlaylistWithTreeOfFilenames:]':
> /home/philou/sources/gap/user-apps/Cynthiune/PlaylistController.m:490: 
> undefined reference to `fileIsAReadableDirectory'
> /home/philou/sources/gap/user-apps/Cynthiune/PlaylistController.m:495: 
> undefined reference to `fileIsAcceptable'
> ./obj/Cynthiune.obj/PlaylistViewController.m.o: In function 
> `-[PlaylistViewController _acceptFilesInPasteboard:]':
> /home/philou/sources/gap/user-apps/Cynthiune/PlaylistViewController.m:462: 
> undefined reference to `fileIsAReadableDirectory'
> ./obj/Cynthiune.obj/Song.m.o: In function `-[Song _refreshSongInfos]':
> /home/philou/sources/gap/user-apps/Cynthiune/Song.m:221: undefined reference 
> to `makeTitleFromFilename'
> ./obj/Cynthiune.obj/Song.m.o: In function `-[Song _readInfos]':
> /home/philou/sources/gap/user-apps/Cynthiune/Song.m:236: undefined reference 
> to `fileIsAcceptable'
> ./obj/Cynthiune.obj/Song.m.o: In function `-[Song setFilename:]':
> /home/philou/sources/gap/user-apps/Cynthiune/Song.m:259: undefined reference 
> to `fileIsAcceptable'
> ./obj/Cynthiune.obj/Song.m.o: In function `-[Song 
> reverseCompareByPlaylistRepresentation:]':
> /home/philou/sources/gap/user-apps/Cynthiune/Song.m:460: undefined reference 
> to `reverseComparisonResult'
> ./obj/Cynthiune.obj/Song.m.o: In function `-[Song reverseCompareByDuration:]':
> /home/philou/sources/gap/user-apps/Cynthiune/Song.m:471: undefined reference 
> to `reverseComparisonResult'
> collect2: ld a retourné 1 code d'état d'exécution
> make[3]: *** [Cynthiune.app/./Cynthiune] Erreur 1
> make[2]: *** [internal-app-run-compile-submake] Erreur 2
> make[1]: *** [Cynthiune.all.app.variables] Erreur 2
> make: *** [internal-all] Erreur 2


diff -u -r1.2 SongInspectorController.m
--- SongInspectorController.m   25 Mar 2012 09:20:43 -0000      1.2
+++ SongInspectorController.m   30 Apr 2012 06:47:13 -0000
@@ -34,11 +34,7 @@
 #import <Foundation/NSString.h>
 #import <Foundation/NSThread.h>

-#ifdef __OpenBSD__
 #import <musicbrainz3/mb_c.h>
-#else
-#import <musicbrainz/mb_c.h>
-#endif

 #import <Cynthiune/Format.h>
 #import <Cynthiune/NSViewExtensions.h>


Philippe