Re: [ft-devel] Possible SEGV problem in aflatin.c

[Werner LEMBERG]

> Apologies for the direct email but I did send this to the mailing
> list and it appears not to be listed in the archive.

Indeed.  No idea why this happened, sorry.

> I found 3 potential SEGV points in aflatin.c and I was not sure how
> to report/handle them.
>
> The functions af_latin_metrics_init_widths,
> af_latin_metrics_init_blues and af_latin_metrics_check_digits each
> create a buffer using :-
>
>   shaper_buf = af_shaper_buf_create( face );
>
> but they do not test for a NULL return before trying to us it.
>
> In all 3 case should an error be raised or should they just return?

I've just committed a different solution, avoiding allocation
altogether in case HarfBuzz isn't available (if HarfBuzz is available,
the problem can't occur according to the HarfBuzz documentation).

Thanks for the report, and please test!


    Werner