Re: [ft-devel] [freetype-2.9.1] FT_Init_FreeType is missing with cc on Solaris x64

[Alan Coopersmith]

On 05/ 3/18 04:50 PM, suzuki toshiya wrote:
> Dear Alan!
> 
> I have not dreamed that the staff from Sun can help, I'm
> very happy.

Happy to help when I can, I just don't have a lot of time to spare these days.
But making sure FreeType works on Solaris is part of my job - I upgraded the
package we ship in Solaris to FreeType 2.9.0 in March, but haven't had a
chance to get to 2.9.1 yet.  You can see the source to our package at:
https://github.com/oracle/solaris-userland/tree/master/components/x11/lib/freetype
Of the 4 patches we ship, 3 were taken from upstream git, only one is our
downstream change, and all 3 of the upstream ones should go away when we
update to the 2.9.1 release that includes those commits.

> Alan Coopersmith wrote:
>> And for the visibility attributes X.Org uses the ifdefs in:
>> https://cgit.freedesktop.org/xorg/proto/xorgproto/tree/include/X11/Xfuncproto.h#n97
>> (using the original annotations from the Sun compiler before the
>>  attribute form became popularized, but you can see other attributes
>>  in that file are handled correctly as well).
> 
> It's very helpful to understand the lowest version of SunPro C to
> enable visibility feature, thanks! In this case, "__global" style
> is used...
> 
> I guess, latest Oracle cc may accept both of __global and
> __attribute__((visibility)) styles, and both of --xldscope and
> -fvisibility= styles.

Correct.

> If so, there's any preference? If the style like GCC was
> introduced in later (for the compatibility with GCC), using
> GCC-unlike style would be more generic for SunPro C.

Yes, the gcc style was only added very recently for gcc compatibility,
the SunPro-specific style goes back many years/versions.

-- 
        -Alan Coopersmith-               address@hidden
         Oracle Solaris Engineering - https://blogs.oracle.com/alanc