Re: [ft-devel] [freetype-2.9.1] FT_Init_FreeType is missing with cc on Solaris x64

[suzuki toshiya]

Dear Alexei,

>> I would consider -D__GNUC__=4  for Solaris too, only if it also
>> supports GNU style assembler and __builtin_clz.

BTW, I'm negative about the idea to add -D__GNUC__=4 to
non-gcc compilers by autotool, cmake, etc.

If we are discussing about the advice for the developers
using non-gnu toolchains and cannot wait the future release
fixing the issue, "please try CFLAGS='-D__GNUC__=4'" is
good.

But, basically, current problem is because of different
switching of visibility control.

In configure, -fvisibility=hidden availability is checked,
on the other hand, in ftconfig.h, __GNUC__ is checked.
It is natural that non-gcc compilers with -fvisibility=hidden
feature fail to compile.

The expected switching would be:

a) check -fvisibility=hidden availability only if
__GNUC__ >= 4.

b) check __attribute__((visibility("default")))__
availability in autoconf (for any compilers) and enable
if it is available, regardless with gcc version.

there are so many gcc-specific features, so making non-gcc
compilers pretend as if it were gcc is too drastic solution.

This is my personal opinion.

Regards,
mpsuzuki


suzuki toshiya wrote:
> Dear Alexei,
> 
> Thanks, I received after revising the patch X-)
> 
> Regards,
> mpsuzuki
> 
> Alexei Podtelezhnikov wrote:
>>> +#elif defined( __SUNPRO_C ) && __SUNPRO_C >= 0x500
>>> +#define FT_EXPORT( x )  __attribute__(( visibility( "__global" ) ))  x
>> Simply,
>> +#define FT_EXPORT( x )  __global  x
>>
>> I would consider -D__GNUC__=4  for Solaris too, only if it also
>> supports GNU style assembler and __builtin_clz.
>>
> 
> 
> _______________________________________________
> Freetype-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/freetype-devel
>