Re: [ft-devel] new CFF engine

[Octoploid]

Werner LEMBERG <wl <at> gnu.org> writes:

> Adobe, in collaboration with Google, has contributed a new CFF parsing
> and hinting engine.  The last few months it was my job to fully
> integrate the code into FreeType, and I'm very pleased with the
> results. 

>   Please test and enjoy!  

>       Adobe in  collaboration with Google.   It is vastly  superior to
>       the old CFF engine, and it  will replace it in the next release.
>       Right  now,  it  is  still  off by  default,  and  you  have  to
>       explicitly select it using  the new `hinting-engine' property of
>       the cff driver:
> 
>         ...
>         #include FT_CFF_DRIVER_H
> 
>         FT_Library  library;
>         int         engine = FT_CFF_HINTING_ADOBE;
> 
>         ...
>         FT_Property_Set( library, "cff", "hinting-engine", &engine );

Please forgive my naive question, but how would one enable
the new engine by default for testing? 
Is the following enough?

diff --git a/src/cff/cffobjs.c b/src/cff/cffobjs.c
index ebcf189..1b8643d 100644
--- a/src/cff/cffobjs.c
+++ b/src/cff/cffobjs.c
@@ -1056,8 +1056,8 @@
 
 
     /* set default property values */
-    driver->hinting_engine    = FT_CFF_HINTING_FREETYPE;
-    driver->no_stem_darkening = FALSE;
+    driver->hinting_engine    = FT_CFF_HINTING_ADOBE;
+    driver->no_stem_darkening = TRUE;
 
     return FT_Err_Ok;
   }