[pooma-dev] small bugs

[ron hylton]

Here are some small bugs that perhaps should be fixed in CVS.

in Array.h

Array::physicalDomain() should return an object rather than a reference 
because view engines return a temporary layout and the current behavior is 
sometimes returning a reference to the interior of a temporary. Fix:

 inline const Domain_t physicalDomain() const

in IndexFunctionEngine.h

Engine::setDomain() should set firsts_m to be consistent with the 
constructors. Fix:

 void setDomain(const Domain_t &dom)
 {
        domain_m = dom;
   for (int d = 0; d < Dim; ++d)
     firsts_m[d] = domain_m[d].first();
 }

I think IndexFunctionEngine also should have an Engine::layout() member to 
be consistent with other Engines.  The simplest possibility is:

 inline Layout_t layout() const { return Layout_t(domain_m); }

in ForwardingEngine.h

in struct NewEngine
 typedef Engine<Dim, T, CompFwd<NewEngine_t, Components> > Type_t;
should be
 typedef Engine<NewEngine_t::dimensions, T, CompFwd<NewEngine_t, 
Components> > Type_t;

Ron Hylton

_________________________________________________________________
Stop worrying about overloading your inbox - get MSN Hotmail Extra Storage! 
http://join.msn.click-url.com/go/onm00200362ave/direct/01/