Re: [Emms-patches] darcs patch: Fix bug of missing lyrics

[Tassilo Horn]

William Xu <address@hidden> writes:

>>   Note that sort is a destructive function, so the value should store
>>   back after sort.
>
> Since `sort' is destructive, emms-lyrics-alist will be modified in
> place.  I don't understand what your patch does.  It looks like doing
> something similar to (setq foo foo).

Ye's right.  Even destructive functions have to be stored back, cause
while sorting the pointer to the lists car are not updated each time.
So you can loose elements if you don't store the returned list.

See this thread for details.

  http://groups.google.se/group/comp.emacs/browse_thread/thread/606f3c8f0ab8cc53

Bye,
Tassilo