Re: [Emms-patches] darcs patch: Fix bug of missing lyrics

[William Xu]

Ye Wenbin <address@hidden> writes:

>   Note that sort is a destructive function, so the value should store back
>   after sort.

Since `sort' is destructive, emms-lyrics-alist will be modified in
place.  I don't understand what your patch does.  It looks like doing
something similar to (setq foo foo).

> New patches:
>
> [Fix bug of missing lyrics
> Ye Wenbin <address@hidden>**20080403045858
>  
>  Note that sort is a destructive function, so the value should store back
>  after sort.
> ] {
> hunk ./emms-lyrics.el 293
> -        (sort emms-lyrics-alist (lambda (a b) (< (car a) (car b)))))
> +        (setq emms-lyrics-alist
> +              (sort emms-lyrics-alist (lambda (a b) (< (car a) (car b))))))
> }

-- 
William

http://williamxu.net9.org