[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug] error on RET in read-only buffer with org-return-follows-link
From: |
Kévin Le Gouguec |
Subject: |
Re: [bug] error on RET in read-only buffer with org-return-follows-link set to t |
Date: |
Thu, 14 May 2020 23:32:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Gregor Zattler <address@hidden> writes:
> Dear Kévin, org-mode developers,
>
> with `org-return-follows-link` set to `t` in a read-only
> buffer I now get a `Buffer is read-only: #<buffer
> notmuch-startpage.org>` error when pressing ENTER/RETURN
> with point on an org-mode link.
Oh, right, I added '*' to org-return's interactive spec because I was
mimicking newline's; I had not considered the link-following case.
Should be a simple matter of removing this '*' if I'm not mistaken:
diff --git a/lisp/org.el b/lisp/org.el
index be1d1c701..339418314 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17702,7 +17702,7 @@ a timestamp or a link, call `org-open-at-point'.
However, it
will not happen if point is in a table or on a \"dead\"
object (e.g., within a comment). In these case, you need to use
`org-open-at-point' directly."
- (interactive "*i\nP\np")
+ (interactive "i\nP\np")
(let ((context (if org-return-follows-link (org-element-context)
(org-element-at-point))))
(cond
> I use this dozens of times a day and it would be convenient
> if it was possible to resurrect the old behaviour.
Right, terribly sorry for this blunder. I'll try to followup with a
unit test to make sure such a regression doesn't creep in again.
Re: [bug] error on RET in read-only buffer with org-return-follows-link set to t,
Kévin Le Gouguec <=